Merge pull request #413 from bsekisser/sim_regbit_clear_check_valid_reg
authorMichel Pollet <github.com@pollet.net>
Tue, 13 Oct 2020 13:29:33 +0000 (14:29 +0100)
committerGitHub <noreply@github.com>
Tue, 13 Oct 2020 13:29:33 +0000 (14:29 +0100)
Remove kludge "avr_uart_regbit_clear" from uart

1  2 
simavr/sim/avr_uart.c
simavr/sim/sim_regbit.h

Simple merge
@@@ -134,12 -116,11 +134,14 @@@ avr_regbit_get_raw
        return (avr->data[a]) & (rb.mask << rb.bit);
  }
  
 -static inline uint8_t avr_regbit_clear(avr_t * avr, avr_regbit_t rb)
 +static inline uint8_t
 +avr_regbit_clear(
 +      avr_t * avr,
 +      avr_regbit_t rb)
  {
        uint16_t a = rb.reg;
+       if (!a)
+               return 0;
        uint8_t m = rb.mask << rb.bit;
        avr_core_watch_write(avr, a, avr->data[a] & ~m);
        return avr->data[a];