From fdc3bdc3c49f82e13fb671cd1297984782371c6a Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Tue, 25 Jul 2017 11:44:30 +0100 Subject: [PATCH] syscall_proc: code review notes/fix Fix getpgrp(), note other stuff for further review --- Kernel/syscall_proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Kernel/syscall_proc.c b/Kernel/syscall_proc.c index 841285c9..eb37a1b1 100644 --- a/Kernel/syscall_proc.c +++ b/Kernel/syscall_proc.c @@ -235,6 +235,7 @@ arg_t _brk(void) the extra as we no longer guarantee it is clear already */ if (addr > udata.u_break) uzero((void *)udata.u_break, addr - udata.u_break); + /* FIXME: review can brk() below base address */ udata.u_break = addr; return 0; } @@ -601,8 +602,7 @@ getpgrp (void) Function 61 arg_t _getpgrp(void) { - udata.u_ptab->p_pgrp = udata.u_ptab->p_pid; - return (0); + return udata.u_ptab->p_pgrp; } /******************************************* -- 2.34.1