From f886b3fb2bad77ca7158057b48add16050ceca2a Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Fri, 28 Aug 2020 19:42:17 +0100 Subject: [PATCH] fix corner case in `loops` & `unused` (#4083) fixes #4082 --- lib/compress.js | 2 +- test/compress/loops.js | 24 ++++++++++++++++++++++++ 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index 90dd0f27..bab390cf 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -4800,7 +4800,7 @@ merge(Compressor.prototype, { return true; } if (node instanceof AST_ForIn) { - if (!compressor.option("loops")) return; + if (!drop_vars || !compressor.option("loops")) return; if (!is_empty(node.body)) return; if (node.init.has_side_effects(compressor)) return; node.object.walk(tw); diff --git a/test/compress/loops.js b/test/compress/loops.js index 23d46de1..e24b3712 100644 --- a/test/compress/loops.js +++ b/test/compress/loops.js @@ -985,3 +985,27 @@ issue_4075: { } expect_stdout: "PASS" } + +issue_4082: { + options = { + keep_fargs: "strict", + loops: true, + unused: true, + } + input: { + var a = "PASS"; + (function(a) { + for (a in "foo") + var b; + })(); + console.log(a); + } + expect: { + var a = "PASS"; + (function(a) { + for (a in "foo"); + })(); + console.log(a); + } + expect_stdout: "PASS" +} -- 2.34.1