From c97ad98f92282bfa52f7d89dd5703021df6bec29 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Tue, 2 Jun 2020 16:50:40 +0100 Subject: [PATCH] fix corner case in `evaluate` (#3946) fixes #3944 --- lib/compress.js | 2 +- test/compress/evaluate.js | 29 +++++++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index 3728884f..cfe37d0b 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -3308,7 +3308,7 @@ merge(Compressor.prototype, { } var op = this.operator; var node; - if (HOP(lhs, "_eval") || !(lhs instanceof AST_SymbolRef) || !lhs.fixed_value()) { + if (HOP(lhs, "_eval") || !(lhs instanceof AST_SymbolRef) || !lhs.fixed || !lhs.definition().fixed) { node = op == "=" ? this.right : make_node(AST_Binary, this, { operator: op.slice(0, -1), left: lhs, diff --git a/test/compress/evaluate.js b/test/compress/evaluate.js index 6deabafa..4e3bc725 100644 --- a/test/compress/evaluate.js +++ b/test/compress/evaluate.js @@ -2690,3 +2690,32 @@ issue_3937: { } expect_stdout: "124 124" } + +issue_3944: { + options = { + collapse_vars: true, + evaluate: true, + inline: true, + reduce_vars: true, + unused: true, + } + input: { + (function() { + function f() { + while (function() { + var a = 0 == (b && b.p), b = console.log(a); + }()); + f; + } + f(); + })(); + } + expect: { + void function f() { + while (a = 0 == (a = void 0), console.log(a), void 0); + var a; + f; + }(); + } + expect_stdout: "false" +} -- 2.34.1