From c526da59a1a9b1a1c5689cfdcc840b36850ed250 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Mon, 27 Mar 2017 18:09:35 +0800 Subject: [PATCH] `has_side_effects()` should take `AST_Switch.expression` into account (#1699) fixes #1698 --- lib/compress.js | 8 ++++++-- test/compress/switch.js | 21 +++++++++++++++++++++ 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/lib/compress.js b/lib/compress.js index 03c8d5dd..1146f300 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -1610,9 +1610,13 @@ merge(Compressor.prototype, { def(AST_Block, function(compressor){ return any(this.body, compressor); }); + def(AST_Switch, function(compressor){ + return this.expression.has_side_effects(compressor) + || any(this.body, compressor); + }); def(AST_Case, function(compressor){ - return any(this.body, compressor) - || this.expression.has_side_effects(compressor); + return this.expression.has_side_effects(compressor) + || any(this.body, compressor); }); def(AST_Try, function(compressor){ return any(this.body, compressor) diff --git a/test/compress/switch.js b/test/compress/switch.js index c3e76302..9f9d3568 100644 --- a/test/compress/switch.js +++ b/test/compress/switch.js @@ -593,3 +593,24 @@ if_switch_typeof: { a; } } + +issue_1698: { + options = { + side_effects: true, + } + input: { + var a = 1; + !function() { + switch (a++) {} + }(); + console.log(a); + } + expect: { + var a = 1; + !function() { + switch (a++) {} + }(); + console.log(a); + } + expect_stdout: "2" +} -- 2.34.1