From bb3bad743c50004f447e1d4eb83b0452e6cd5c7b Mon Sep 17 00:00:00 2001 From: Jakub Pawlowicz Date: Tue, 28 Apr 2015 09:41:26 +0100 Subject: [PATCH] Fixes #556 - regression in IE backslash hacks. --- History.md | 5 +++++ lib/stringifier/helpers.js | 2 +- test/integration-test.js | 10 +++++----- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/History.md b/History.md index 0a10b9ed..e18f1adb 100644 --- a/History.md +++ b/History.md @@ -9,6 +9,11 @@ * Moves URL rebasing & rewriting into lib/urls. * Fixed issue [#436](https://github.com/jakubpawlowicz/clean-css/issues/436) - refactors URI rewriting. +[3.2.6 / 2015-xx-xx](https://github.com/jakubpawlowicz/clean-css/compare/v3.2.5...3.2) +================== + +* Fixed issue [#556](https://github.com/jakubpawlowicz/clean-css/issues/556) - regression in IE backslash hacks. + [3.2.5 / 2015-04-25](https://github.com/jakubpawlowicz/clean-css/compare/v3.2.4...v3.2.5) ================== diff --git a/lib/stringifier/helpers.js b/lib/stringifier/helpers.js index 8c2a244b..0e0b31ba 100644 --- a/lib/stringifier/helpers.js +++ b/lib/stringifier/helpers.js @@ -1,7 +1,7 @@ var lineBreak = require('os').EOL; var STAR_HACK = '*'; -var SUFFIX_HACK = '\\0'; +var SUFFIX_HACK = '\\9'; var UNDERSCORE_HACK = '_'; function hasMoreProperties(tokens, index) { diff --git a/test/integration-test.js b/test/integration-test.js index a7fdce0a..67cb740f 100644 --- a/test/integration-test.js +++ b/test/integration-test.js @@ -1127,10 +1127,10 @@ path")}', 'IE hacks': cssContext({ 'star': 'a{*color:#fff}', 'unserscore': 'a{_color:#fff}', - 'backslash': 'a{color:#fff\\0}', + 'backslash': 'a{color:#fff\\9}', 'overriding by a star': 'a{color:red;display:block;*color:#fff}', 'overriding by a unserscore': 'a{color:red;display:block;_color:#fff}', - 'overriding by a backslash': 'a{color:red;display:block;color:#fff\\0}', + 'overriding by a backslash': 'a{color:red;display:block;color:#fff\\9}', 'overriding a star': [ 'a{*color:red;display:block;*color:#fff}', 'a{display:block;*color:#fff}' @@ -1141,12 +1141,12 @@ path")}', ], 'overriding a backslash': [ 'a{color:red\\9;display:block;color:#fff\\9}', - 'a{display:block;color:#fff\\0}' + 'a{display:block;color:#fff\\9}' ], 'overriding a star by a non-ajacent selector': 'a{color:red}.one{color:#000}a{*color:#fff}', 'overriding an underscore by a non-ajacent selector': 'a{color:red}.one{color:#000}a{_color:#fff}', - 'overriding a backslash by a non-ajacent selector': 'a{color:red}.one{color:#fff}a{color:#fff\\0}', - 'preserving backslash in overriddable': 'a{border:1px solid #ccc\\0}', + 'overriding a backslash by a non-ajacent selector': 'a{color:red}.one{color:#fff}a{color:#fff\\9}', + 'preserving backslash in overriddable': 'a{border:1px solid #ccc\\9}', 'keeps rgba(0,0,0,0)': 'a{color:rgba(0,0,0,0)}', 'keeps rgba(255,255,255,0)': 'a{color:rgba(255,255,255,0)}', 'keeps hsla(120,100%,50%,0)': 'a{color:hsla(120,100%,50%,0)}' -- 2.34.1