From b8c39303efe7a3868e862d70f3e317478a5cd5cf Mon Sep 17 00:00:00 2001 From: Jakub Pawlowicz Date: Mon, 20 Mar 2017 15:03:56 +0100 Subject: [PATCH] Fixes #917 - prevents grid area unquoting. Why: * Specification requires such values to be quoted so should the values be preserved. --- History.md | 5 +++++ lib/optimizer/level-1/optimize.js | 2 +- test/optimizer/level-1/optimize-test.js | 16 ++++++++++++++++ 3 files changed, 22 insertions(+), 1 deletion(-) diff --git a/History.md b/History.md index 2af83c3f..1bcc55e9 100644 --- a/History.md +++ b/History.md @@ -7,6 +7,11 @@ * Fixed issue [#890](https://github.com/jakubpawlowicz/clean-css/issues/890) - adds toggle to disable empty tokens removal. * Fixed issue [#886](https://github.com/jakubpawlowicz/clean-css/issues/886) - better multi pseudo class / element merging. +[4.0.10 / 2017-xx-xx](https://github.com/jakubpawlowicz/clean-css/compare/v4.0.9...4.0) +================== + +* Fixed issue [#917](https://github.com/jakubpawlowicz/clean-css/issues/917) - prevents grid area unquoting. + [4.0.9 / 2017-03-15](https://github.com/jakubpawlowicz/clean-css/compare/v4.0.8...v4.0.9) ================== diff --git a/lib/optimizer/level-1/optimize.js b/lib/optimizer/level-1/optimize.js index 9c0b65ba..76d4f06d 100644 --- a/lib/optimizer/level-1/optimize.js +++ b/lib/optimizer/level-1/optimize.js @@ -390,7 +390,7 @@ function optimizeZeroUnits(name, value) { } function removeQuotes(name, value) { - if (name == 'content' || name.indexOf('font-feature-settings') > -1) { + if (name == 'content' || name.indexOf('font-feature-settings') > -1 || name.indexOf('grid-') > -1) { return value; } diff --git a/test/optimizer/level-1/optimize-test.js b/test/optimizer/level-1/optimize-test.js index 6f66d932..5a5dd666 100644 --- a/test/optimizer/level-1/optimize-test.js +++ b/test/optimizer/level-1/optimize-test.js @@ -1136,6 +1136,22 @@ vows.describe('level 1 optimizations') '-webkit-font-feature-settings': [ '.block{-webkit-font-feature-settings:"scmp","swsh" 2}', '.block{-webkit-font-feature-settings:"scmp","swsh" 2}' + ], + 'grid-template': [ + '.block{grid-template:"header" 20% "nav" auto}', + '.block{grid-template:"header" 20% "nav" auto}' + ], + 'grid-template-areas - single word': [ + '.block{grid-template-areas:"header" "nav" "body"}', + '.block{grid-template-areas:"header" "nav" "body"}' + ], + 'grid-template-areas - multiple words': [ + '.block{grid-template-areas:"header header" "nav" "body"}', + '.block{grid-template-areas:"header header" "nav" "body"}' + ], + 'vendor prefixed grid-template': [ + '.block{-ms-grid-template:"header" 20% "nav" auto}', + '.block{-ms-grid-template:"header" 20% "nav" auto}' ] }, { level: 1 }) ) -- 2.34.1