From 9f1f21b810ba3b996236cc7ef6757657757a007a Mon Sep 17 00:00:00 2001 From: kzc Date: Mon, 12 Oct 2015 00:20:42 -0400 Subject: [PATCH] Output `-- >` instead of `-->` in expressions. Escape `` within string literals. --- lib/output.js | 13 +++++++++++-- test/compress/html_comments.js | 15 +++++++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 test/compress/html_comments.js diff --git a/lib/output.js b/lib/output.js index c15f3b20..8ca0dc06 100644 --- a/lib/output.js +++ b/lib/output.js @@ -127,6 +127,8 @@ function OutputStream(options) { var ret = make_string(str, quote); if (options.inline_script) ret = ret.replace(/<\x2fscript([>\/\t\n\f\r ])/gi, "<\\/script$1"); + ret = ret.replace(/\x3c!--/g, "\\x3c!--"); + ret = ret.replace(/--\x3e/g, "--\\x3e"); return ret; }; @@ -1046,7 +1048,15 @@ function OutputStream(options) { }); DEFPRINT(AST_Binary, function(self, output){ self.left.print(output); - output.space(); + if (self.operator == ">" + && self.left instanceof AST_UnaryPostfix + && self.left.operator == "--") { + // space is mandatory to avoid outputting --> + output.print(" "); + } else { + // the space is optional depending on "beautify" + output.space(); + } output.print(self.operator); if (self.operator == "<" && self.right instanceof AST_UnaryPrefix @@ -1054,7 +1064,6 @@ function OutputStream(options) { && self.right.expression instanceof AST_UnaryPrefix && self.right.expression.operator == "--") { // space is mandatory to avoid outputting comment in"; } + } + expect_exact: 'function f(){return"\\x3c!--HTML--\\x3ecomment in\\x3c!--string literal--\\x3e"}'; +} + + -- 2.34.1