From 86a17089921dbcd800db76835503619cb7e65e2e Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Tue, 19 Feb 2019 00:20:05 +0000 Subject: [PATCH] filesys: not an optimization to look into --- Kernel/filesys.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Kernel/filesys.c b/Kernel/filesys.c index 52cb8bfd..043871eb 100644 --- a/Kernel/filesys.c +++ b/Kernel/filesys.c @@ -1321,7 +1321,11 @@ void magic(inoptr ino) /* This is a helper function used by _unlink and _rename; it doesn't really * belong here, but needs to be in common code as it's used from two different - * syscall banks. */ + * syscall banks. + * + * FIXME: this could be more efficient if we remembered which directory offset + * we found the node at lookup time + */ arg_t unlinki(inoptr ino, inoptr pino, char *fname) { if (getmode(ino) == MODE_R(F_DIR)) { -- 2.34.1