From 570e5905460fae4eac31274b2a44e0d102117fa3 Mon Sep 17 00:00:00 2001 From: Alan Cox Date: Tue, 19 May 2015 22:18:27 +0100 Subject: [PATCH] tty: note some items to review --- Kernel/tty.c | 1 + Kernel/vt.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Kernel/tty.c b/Kernel/tty.c index 81f155b4..0b446303 100644 --- a/Kernel/tty.c +++ b/Kernel/tty.c @@ -177,6 +177,7 @@ int tty_open(uint8_t minor, uint16_t flag) if ((t->termios.c_cflag & CLOCAL) || (flag & O_NDELAY)) return 0; + /* FIXME: racy - need to handle IRQ driven carrier events safely */ if (!tty_carrier(minor)) { if (psleep_flags(&t->termios.c_cflag, flag)) return -1; diff --git a/Kernel/vt.c b/Kernel/vt.c index 1605c2d3..06f809db 100644 --- a/Kernel/vt.c +++ b/Kernel/vt.c @@ -192,6 +192,7 @@ int vt_ioctl(uint8_t minor, uarg_t request, char *data) { /* FIXME: need to address the multiple vt switching case here.. probably need to switch vt */ + /* FIXME: minor 0 handling */ if (minor <= MAX_VT) { switch(request) { #ifdef KEY_ROWS -- 2.34.1