From 56fce2131c86ed58ac00bb27b308054b1c2a669f Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Wed, 23 Dec 2020 20:09:09 +0000 Subject: [PATCH] fix corner case in `pure_getters` (#4441) fixes #4440 --- lib/compress.js | 3 ++- test/compress/pure_getters.js | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index c397a605..13b7306b 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -3237,7 +3237,8 @@ merge(Compressor.prototype, { if (!is_strict(compressor)) return false; if (is_undeclared_ref(this) && this.is_declared(compressor)) return false; if (this.is_immutable()) return false; - if (is_arguments(this.definition())) return false; + var def = this.definition(); + if (is_arguments(def)) return def.scope.uses_arguments > 2; var fixed = this.fixed_value(); if (!fixed) return true; this._dot_throw = return_true; diff --git a/test/compress/pure_getters.js b/test/compress/pure_getters.js index 25efd7fd..1cb2ff13 100644 --- a/test/compress/pure_getters.js +++ b/test/compress/pure_getters.js @@ -1208,3 +1208,32 @@ issue_3427: { expect: {} expect_stdout: true } + +issue_4440: { + options = { + pure_getters: "strict", + side_effects: true, + unused: true, + } + input: { + try { + (function() { + arguments = null; + console.log(arguments.p = "FAIL"); + })(); + } catch (e) { + console.log("PASS"); + } + } + expect: { + try { + (function() { + arguments = null; + console.log(arguments.p = "FAIL"); + })(); + } catch (e) { + console.log("PASS"); + } + } + expect_stdout: "PASS" +} -- 2.34.1