From 516eaef50c66aede72d3478a5653ae8651806258 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Sun, 22 Oct 2017 13:14:15 +0800 Subject: [PATCH] fix `unsafe` evaluation of `AST_Sub` (#2389) --- lib/compress.js | 1 + test/compress/properties.js | 21 ++++++++++++++++++++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/lib/compress.js b/lib/compress.js index cef5d75f..6a40ef2a 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -4468,6 +4468,7 @@ merge(Compressor.prototype, { }); } } + if (is_lhs(self, compressor.parent())) return self; var ev = self.evaluate(compressor); if (ev !== self) { ev = make_node_from_constant(ev, self).optimize(compressor); diff --git a/test/compress/properties.js b/test/compress/properties.js index c8a85697..45f870df 100644 --- a/test/compress/properties.js +++ b/test/compress/properties.js @@ -805,7 +805,7 @@ issue_2256: { } } -lhs_prop: { +lhs_prop_1: { options = { evaluate: true, unsafe: true, @@ -822,3 +822,22 @@ lhs_prop: { } expect_stdout: "2" } + +lhs_prop_2: { + options = { + evaluate: true, + inline: true, + reduce_vars: true, + side_effects: true, + unsafe: true, + unused: true, + } + input: { + (function(a) { + a[2] = "g"; + })("abc"); + } + expect: { + "abc"[2] = "g"; + } +} -- 2.34.1