From 4bceb85cbfa2c944fb97bb3baaa403b266d075c6 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Tue, 21 Mar 2017 14:11:32 +0800 Subject: [PATCH] throw parse error on invalid assignments (#1627) fixes #1626 --- lib/parse.js | 4 +--- test/compress/html_comments.js | 16 ---------------- 2 files changed, 1 insertion(+), 19 deletions(-) diff --git a/lib/parse.js b/lib/parse.js index 25fe9319..4d37b85e 100644 --- a/lib/parse.js +++ b/lib/parse.js @@ -1501,9 +1501,7 @@ function parse($TEXT, options) { }; function is_assignable(expr) { - if (!options.strict) return true; - if (expr instanceof AST_This) return false; - return (expr instanceof AST_PropAccess || expr instanceof AST_Symbol); + return expr instanceof AST_PropAccess || expr instanceof AST_SymbolRef; }; var maybe_assign = function(no_in) { diff --git a/test/compress/html_comments.js b/test/compress/html_comments.js index 8495b433..fe6ff8ac 100644 --- a/test/compress/html_comments.js +++ b/test/compress/html_comments.js @@ -47,22 +47,6 @@ html_comment_in_greater_than_or_equal: { expect_exact: "function f(a,b){return a-- >=b}"; } -html_comment_in_right_shift_assign: { - input: { - // Note: illegal javascript - function f(a, b) { return a-- >>= b; } - } - expect_exact: "function f(a,b){return a-- >>=b}"; -} - -html_comment_in_zero_fill_right_shift_assign: { - input: { - // Note: illegal javascript - function f(a, b) { return a-- >>>= b; } - } - expect_exact: "function f(a,b){return a-- >>>=b}"; -} - html_comment_in_string_literal: { input: { function f() { return "comment in"; } -- 2.34.1