From 3d5bc081851897648ccc71009a2138240fe41fa0 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Fri, 23 Jun 2017 04:44:57 +0800 Subject: [PATCH] fix `reduce_vars` on `this` (#2145) fixes #2140 --- lib/compress.js | 10 +++++----- test/compress/reduce_vars.js | 25 +++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 5 deletions(-) diff --git a/lib/compress.js b/lib/compress.js index aa7affc4..c332282f 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -279,11 +279,11 @@ merge(Compressor.prototype, { var reduce_vars = rescan && compressor.option("reduce_vars"); var safe_ids = Object.create(null); var suppressor = new TreeWalker(function(node) { - if (node instanceof AST_Symbol) { - var d = node.definition(); - if (node instanceof AST_SymbolRef) d.references.push(node); - d.fixed = false; - } + if (!(node instanceof AST_Symbol)) return; + var d = node.definition(); + if (!d) return; + if (node instanceof AST_SymbolRef) d.references.push(node); + d.fixed = false; }); var tw = new TreeWalker(function(node, descend) { node._squeezed = false; diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js index cef29832..5906a971 100644 --- a/test/compress/reduce_vars.js +++ b/test/compress/reduce_vars.js @@ -2575,3 +2575,28 @@ accessor: { } expect_stdout: "1 1" } + +for_in_prop: { + options = { + reduce_vars: true, + } + input: { + var a = { + foo: function() { + for (this.b in [1, 2]); + } + }; + a.foo(); + console.log(a.b); + } + expect: { + var a = { + foo: function() { + for (this.b in [1, 2]); + } + }; + a.foo(); + console.log(a.b); + } + expect_stdout: "1" +} -- 2.34.1