From 0dcedad2d5a6b670ecd5aef3cf18d5e511af6e91 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Tue, 28 Jan 2020 02:04:44 +0800 Subject: [PATCH] fix corner case in `booleans` (#3691) fixes #3690 --- lib/compress.js | 4 ++-- test/compress/booleans.js | 22 ++++++++++++++++++++++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/lib/compress.js b/lib/compress.js index a3baa7b1..4e967aef 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -4453,7 +4453,7 @@ merge(Compressor.prototype, { var ev = value.is_truthy() || value.tail_node().evaluate(compressor); if (!ev) { value = value.drop_side_effect_free(compressor); - if (node.value !== value) node.value = value ? make_sequence(node.value, [ + node.value = value ? make_sequence(node.value, [ value, make_node(AST_Number, node.value, { value: 0 @@ -4461,7 +4461,7 @@ merge(Compressor.prototype, { ]) : null; } else if (ev && !(ev instanceof AST_Node)) { value = value.drop_side_effect_free(compressor); - if (node.value !== value) node.value = value ? make_sequence(node.value, [ + node.value = value ? make_sequence(node.value, [ value, make_node(AST_Number, node.value, { value: 1 diff --git a/test/compress/booleans.js b/test/compress/booleans.js index e1fa1a4f..6e7988bf 100644 --- a/test/compress/booleans.js +++ b/test/compress/booleans.js @@ -131,3 +131,25 @@ issue_3658: { } expect_stdout: "PASS" } + +issue_3690: { + options = { + booleans: true, + unused: true, + } + input: { + console.log(function(a) { + return function() { + return a = [ this ]; + }() ? "PASS" : "FAIL"; + }()); + } + expect: { + console.log(function(a) { + return function() { + return 1; + }() ? "PASS" : "FAIL"; + }()); + } + expect_stdout: "PASS" +} -- 2.34.1