From 0785a15aceaee3f4a31d9693a4230cbf0477ea81 Mon Sep 17 00:00:00 2001 From: "Alex Lam S.L" Date: Thu, 17 Oct 2019 09:58:05 +0800 Subject: [PATCH] fix corner case in `dead_code` & `ie8` (#3494) fixes #3493 --- lib/compress.js | 6 ++-- test/compress/ie8.js | 72 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 76 insertions(+), 2 deletions(-) diff --git a/lib/compress.js b/lib/compress.js index e39435c7..4b0ceee4 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -888,8 +888,10 @@ merge(Compressor.prototype, { }); AST_SymbolRef.DEFMETHOD("is_immutable", function() { - var orig = this.definition().orig; - return orig.length == 1 && orig[0] instanceof AST_SymbolLambda; + var def = this.definition(); + if (def.orig.length != 1) return false; + var sym = def.orig[0]; + return sym instanceof AST_SymbolLambda && def.scope.name === sym; }); function is_lhs_read_only(lhs, compressor) { diff --git a/test/compress/ie8.js b/test/compress/ie8.js index 223da329..4637451c 100644 --- a/test/compress/ie8.js +++ b/test/compress/ie8.js @@ -1887,3 +1887,75 @@ issue_3486_ie8: { } expect_stdout: "PASS" } + +issue_3493: { + options = { + dead_code: true, + ie8: false, + } + input: { + var c = "PASS"; + (function() { + try { + (function a() { + throw {}; + })(); + } catch (a) { + a >>= 0; + a && (c = "FAIL"); + } + })(); + console.log(c); + } + expect: { + var c = "PASS"; + (function() { + try { + (function a() { + throw {}; + })(); + } catch (a) { + a >>= 0; + a && (c = "FAIL"); + } + })(); + console.log(c); + } + expect_stdout: "PASS" +} + +issue_3493_ie8: { + options = { + dead_code: true, + ie8: true, + } + input: { + var c = "PASS"; + (function() { + try { + (function a() { + throw {}; + })(); + } catch (a) { + a >>= 0; + a && (c = "FAIL"); + } + })(); + console.log(c); + } + expect: { + var c = "PASS"; + (function() { + try { + (function a() { + throw {}; + })(); + } catch (a) { + a >>= 0; + a && (c = "FAIL"); + } + })(); + console.log(c); + } + expect_stdout: "PASS" +} -- 2.34.1