From 0281e99931fbdffbcf546234b30e6a343ca9bccf Mon Sep 17 00:00:00 2001 From: Jakub Pawlowicz Date: Wed, 8 Feb 2017 08:35:01 +0100 Subject: [PATCH] Fixes #885 - don't strip quotes from `font-feature-settings`. Why: * Browsers don't get it right when without quotes; * it'll all be better with whitelist based optimizations, see #889. --- History.md | 5 +++++ lib/optimizer/level-1/optimize.js | 2 +- test/optimizer/level-1/optimize-test.js | 8 ++++++++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/History.md b/History.md index d0e9c44e..872fe5f8 100644 --- a/History.md +++ b/History.md @@ -1,3 +1,8 @@ +[4.0.6 / 2017-xx-xx](https://github.com/jakubpawlowicz/clean-css/compare/v4.0.5...4.0) +================== + +* Fixed issue [#885](https://github.com/jakubpawlowicz/clean-css/issues/885) - unquoting `font-feature-settings`. + [4.0.5 / 2017-02-07](https://github.com/jakubpawlowicz/clean-css/compare/v4.0.4...v4.0.5) ================== diff --git a/lib/optimizer/level-1/optimize.js b/lib/optimizer/level-1/optimize.js index ced1d6d8..edb545c2 100644 --- a/lib/optimizer/level-1/optimize.js +++ b/lib/optimizer/level-1/optimize.js @@ -391,7 +391,7 @@ function optimizeZeroUnits(name, value) { } function removeQuotes(name, value) { - if (name == 'content') { + if (name == 'content' || name.indexOf('font-feature-settings') > -1) { return value; } diff --git a/test/optimizer/level-1/optimize-test.js b/test/optimizer/level-1/optimize-test.js index d37d34e1..21a9f27d 100644 --- a/test/optimizer/level-1/optimize-test.js +++ b/test/optimizer/level-1/optimize-test.js @@ -1084,6 +1084,14 @@ vows.describe('level 1 optimizations') 'variable': [ '.block{--font-family:"Arial"}', '.block{--font-family:"Arial"}' + ], + 'font-feature-settings': [ + '.block{font-feature-settings:"scmp" on}', + '.block{font-feature-settings:"scmp" on}' + ], + '-webkit-font-feature-settings': [ + '.block{-webkit-font-feature-settings:"scmp","swsh" 2}', + '.block{-webkit-font-feature-settings:"scmp","swsh" 2}' ] }, { level: 1 }) ) -- 2.34.1