From: Alex Lam S.L <alexlamsl@gmail.com>
Date: Fri, 5 Jun 2020 06:28:08 +0000 (+0100)
Subject: fix corner case in `collapse_vars` (#3954)
X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=fbc9d8009bee522fe784602ba8b157a38a45bd69;p=UglifyJS.git

fix corner case in `collapse_vars` (#3954)
---

diff --git a/lib/compress.js b/lib/compress.js
index 17b3ecf7..23a9f923 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -1832,13 +1832,13 @@ merge(Compressor.prototype, {
                         return make_node(AST_SymbolRef, expr.name, expr.name);
                     }
                 } else if (expr instanceof AST_Assign) {
-                    var lhs = expr.left;
-                    if (expr.operator == "=" && lhs instanceof AST_SymbolRef) {
-                        var def = lhs.definition();
-                        if (def.references[0] === lhs) {
-                            var referenced = def.references.length - def.replaced;
-                            if (referenced > 1) mangleable_var(expr.right);
-                        }
+                    var def, lhs = expr.left;
+                    if (expr.operator == "="
+                        && lhs instanceof AST_SymbolRef
+                        && (def = lhs.definition()).references[0] === lhs
+                        && !compressor.exposed(def)) {
+                        var referenced = def.references.length - def.replaced;
+                        if (referenced > 1) mangleable_var(expr.right);
                     }
                     return lhs;
                 } else {
diff --git a/test/compress/collapse_vars.js b/test/compress/collapse_vars.js
index cea5ca84..0c232aa0 100644
--- a/test/compress/collapse_vars.js
+++ b/test/compress/collapse_vars.js
@@ -6888,6 +6888,30 @@ sequence_in_iife_2: {
     }
     expect: {
         var a = "foo", b = 42;
+        b = a;
+        console.log(a, b);
+    }
+    expect_stdout: "foo foo"
+}
+
+sequence_in_iife_3: {
+    options = {
+        collapse_vars: true,
+        inline: true,
+        passes: 2,
+        side_effects: true,
+        toplevel: true,
+        unused: true,
+    }
+    input: {
+        var a = "foo", b = 42;
+        (function() {
+            var c = (b = a, b);
+        })();
+        console.log(a, b);
+    }
+    expect: {
+        var a = "foo";
         console.log(a, a);
     }
     expect_stdout: "foo foo"