From: Alex Lam S.L <alexlamsl@gmail.com>
Date: Fri, 25 May 2018 21:45:44 +0000 (+0800)
Subject: fix corner case in `reduce_vars` (#3151)
X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=efa21ae3e6c7399913f98cc01f8888bf6158ae49;p=UglifyJS.git

fix corner case in `reduce_vars` (#3151)
---

diff --git a/lib/compress.js b/lib/compress.js
index ebb2d408..1832f7a8 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -388,7 +388,6 @@ merge(Compressor.prototype, {
                         tw.defun_ids[def.id] = false;
                     }
                 });
-                return true;
             };
         }
 
@@ -565,7 +564,7 @@ merge(Compressor.prototype, {
             return true;
         });
         def(AST_Call, function(tw, descend) {
-            if (tw.find_parent(AST_Scope).may_call_this()) return;
+            tw.find_parent(AST_Scope).may_call_this();
             var exp = this.expression;
             if (!(exp instanceof AST_SymbolRef)) return;
             var def = exp.definition();
diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js
index 626893f4..0af80da5 100644
--- a/test/compress/reduce_vars.js
+++ b/test/compress/reduce_vars.js
@@ -6367,3 +6367,39 @@ issue_3140_4: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3140_5: {
+    options = {
+        evaluate: true,
+        reduce_vars: true,
+    }
+    input: {
+        var n = 1, c = 0;
+        (function(a) {
+            var b = function() {
+                this;
+                n-- && h();
+            }();
+            function h() {
+                b && c++;
+            }
+            h(b = 1);
+        })();
+        console.log(c);
+    }
+    expect: {
+        var n = 1, c = 0;
+        (function(a) {
+            var b = function() {
+                this;
+                n-- && h();
+            }();
+            function h() {
+                b && c++;
+            }
+            h(b = 1);
+        })();
+        console.log(c);
+    }
+    expect_stdout: "1"
+}