From: Alex Lam S.L <alexlamsl@gmail.com>
Date: Wed, 30 Oct 2019 06:21:22 +0000 (+0800)
Subject: fix corner case in `dead_code` (#3553)
X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=ec7f071272384db82dff0f8fb6629f4f6fee43a5;p=UglifyJS.git

fix corner case in `dead_code` (#3553)

fixes #3552
---

diff --git a/lib/compress.js b/lib/compress.js
index 33943ff0..a28c7a6c 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -6433,15 +6433,17 @@ merge(Compressor.prototype, {
     OPT(AST_Assign, function(self, compressor) {
         if (compressor.option("dead_code")) {
             if (self.left instanceof AST_PropAccess) {
-                var exp = self.left.expression;
-                if (exp instanceof AST_Lambda
-                    || !compressor.has_directive("use strict")
-                        && exp instanceof AST_Constant
-                        && !exp.may_throw_on_access(compressor)) {
-                    return self.left instanceof AST_Dot ? self.right : make_sequence(self, [
-                        self.left.property,
-                        self.right
-                    ]).optimize(compressor);
+                if (self.operator == "=") {
+                    var exp = self.left.expression;
+                    if (exp instanceof AST_Lambda
+                        || !compressor.has_directive("use strict")
+                            && exp instanceof AST_Constant
+                            && !exp.may_throw_on_access(compressor)) {
+                        return self.left instanceof AST_Dot ? self.right : make_sequence(self, [
+                            self.left.property,
+                            self.right
+                        ]).optimize(compressor);
+                    }
                 }
             } else if (self.left instanceof AST_SymbolRef) {
                 var def = self.left.definition();
diff --git a/test/compress/dead-code.js b/test/compress/dead-code.js
index 501d55ec..93fc9f41 100644
--- a/test/compress/dead-code.js
+++ b/test/compress/dead-code.js
@@ -1042,3 +1042,25 @@ function_assign: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3552: {
+    options = {
+        dead_code: true,
+        pure_getters: "strict",
+    }
+    input: {
+        var a = "PASS";
+        (function() {
+            (1..p += 42) && (a = "FAIL");
+        })();
+        console.log(a);
+    }
+    expect: {
+        var a = "PASS";
+        (function() {
+            (1..p += 42) && (a = "FAIL");
+        })();
+        console.log(a);
+    }
+    expect_stdout: "PASS"
+}