From: Alex Lam S.L <alexlamsl@gmail.com>
Date: Mon, 22 Jan 2018 18:49:54 +0000 (+0800)
Subject: drop assignments to constant expressions only (#2839)
X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=ec4202590d040942639e01eb8ae83bf7be7180dd;p=UglifyJS.git

drop assignments to constant expressions only (#2839)

fixes #2838
---

diff --git a/lib/compress.js b/lib/compress.js
index 2803b85c..a8fa0e1c 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -3469,8 +3469,10 @@ merge(Compressor.prototype, {
             while (left instanceof AST_PropAccess) {
                 left = left.expression;
             }
-            if (left instanceof AST_Symbol) return this;
-            return this.right.drop_side_effect_free(compressor);
+            if (left.is_constant_expression(compressor.find_parent(AST_Scope))) {
+                return this.right.drop_side_effect_free(compressor);
+            }
+            return this;
         });
         def(AST_Conditional, function(compressor){
             var consequent = this.consequent.drop_side_effect_free(compressor);
diff --git a/test/compress/pure_getters.js b/test/compress/pure_getters.js
index 80b0e8ea..4e9ae4f4 100644
--- a/test/compress/pure_getters.js
+++ b/test/compress/pure_getters.js
@@ -694,3 +694,30 @@ issue_2678: {
     }
     expect_stdout: "PASS"
 }
+
+issue_2838: {
+    options = {
+        pure_getters: true,
+        side_effects: true,
+    }
+    input: {
+        function f(a, b) {
+            (a || b).c = "PASS";
+            (function() {
+                return f(a, b);
+            }).prototype.foo = "bar";
+        }
+        var o = {};
+        f(null, o);
+        console.log(o.c);
+    }
+    expect: {
+        function f(a, b) {
+            (a || b).c = "PASS";
+        }
+        var o = {};
+        f(null, o);
+        console.log(o.c);
+    }
+    expect_stdout: "PASS"
+}