From: Alex Lam S.L <alexlamsl@gmail.com>
Date: Sat, 24 Oct 2020 14:44:20 +0000 (+0100)
Subject: fix corner case in `collapse_vars` (#4243)
X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=e478da24c7b185322c8898444470036fdec31c0d;p=UglifyJS.git

fix corner case in `collapse_vars` (#4243)

fixes #4242
---

diff --git a/lib/compress.js b/lib/compress.js
index 216ca92a..647c97e1 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -1974,6 +1974,7 @@ merge(Compressor.prototype, {
             }
 
             function foldable(expr) {
+                if (expr instanceof AST_Assign && expr.right.single_use) return;
                 var lhs_ids = Object.create(null);
                 var marker = new TreeWalker(function(node) {
                     if (node instanceof AST_SymbolRef) lhs_ids[node.definition().id] = true;
diff --git a/test/compress/collapse_vars.js b/test/compress/collapse_vars.js
index 4c3a6eda..dea01b60 100644
--- a/test/compress/collapse_vars.js
+++ b/test/compress/collapse_vars.js
@@ -8556,3 +8556,24 @@ issue_4070: {
     }
     expect_stdout: "NaN"
 }
+
+issue_4242: {
+    options = {
+        collapse_vars: true,
+        conditionals: true,
+        reduce_vars: true,
+        unused: true,
+    }
+    input: {
+        console.log(function() {
+            if (console)
+                var a = function(){}, b = (!1 === console || a)();
+        }());
+    }
+    expect: {
+        console.log(function() {
+            console && (!1 === console || function(){})();
+        }());
+    }
+    expect_stdout: "undefined"
+}