From: Alex Lam S.L Date: Wed, 4 Dec 2019 12:24:55 +0000 (+0800) Subject: fix corner case in `reduce_vars` (#3623) X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=d68ddc31f94074e09c661cb79ea43cef9adb44e6;p=UglifyJS.git fix corner case in `reduce_vars` (#3623) fixes #3622 --- diff --git a/lib/compress.js b/lib/compress.js index e18fd575..4442bbb5 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -701,8 +701,11 @@ merge(Compressor.prototype, { node.argnames.forEach(function(arg, i) { var d = arg.definition(); if (d.fixed === undefined && (!node.uses_arguments || tw.has_directive("use strict"))) { + var value = iife.args[i]; d.fixed = function() { - return iife.args[i] || make_node(AST_Undefined, iife); + var j = node.argnames.indexOf(arg); + if (j < 0) return value; + return iife.args[j] || make_node(AST_Undefined, iife); }; tw.loop_ids[d.id] = tw.in_loop; mark(tw, d, true); diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js index a3421c00..443c347d 100644 --- a/test/compress/reduce_vars.js +++ b/test/compress/reduce_vars.js @@ -6774,3 +6774,30 @@ issue_3509: { } expect_stdout: "PASS" } + +issue_3622: { + options = { + evaluate: true, + inline: true, + keep_fargs: "strict", + reduce_vars: true, + sequences: true, + toplevel: true, + unused: true, + } + input: { + var c = "FAIL"; + !function(b, a) { + a && (c = "PASS"); + }(42, this); + console.log(c); + } + expect: { + var c = "FAIL"; + var a; + a = this, + !void (a && (c = "PASS")), + console.log(c); + } + expect_stdout: "PASS" +}