From: Alex Lam S.L Date: Mon, 1 Feb 2021 15:24:11 +0000 (+0000) Subject: fix corner case in `collapse_vars` (#4605) X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=b27b6807cb01b6068cecda435b6b6b2a2ef5af07;p=UglifyJS.git fix corner case in `collapse_vars` (#4605) fixes #4604 --- diff --git a/lib/compress.js b/lib/compress.js index f894a6cb..ac7aa3e0 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -1942,6 +1942,7 @@ merge(Compressor.prototype, { var def = node.definition(); return (in_try || def.scope.resolve() !== scope) && !can_drop_symbol(node); } + if (node instanceof AST_Template) return node.tag && !is_raw_tag(compressor, node.tag); if (node instanceof AST_This) return symbol_in_lvalues(node, parent); if (node instanceof AST_VarDef) { if (check_destructured(node.name)) return true; diff --git a/test/compress/templates.js b/test/compress/templates.js index ef2a534b..3b0e983c 100644 --- a/test/compress/templates.js +++ b/test/compress/templates.js @@ -198,3 +198,27 @@ unsafe_side_effects: { expect_stdout: "foo" node_version: ">=4" } + +issue_4604: { + options = { + collapse_vars: true, + } + input: { + var a = 0, log = console.log; + a = "FAIL"; + (function() { + a = "PASS"; + })``; + log(a); + } + expect: { + var a = 0, log = console.log; + a = "FAIL"; + (function() { + a = "PASS"; + })``; + log(a); + } + expect_stdout: "PASS" + node_version: ">=4" +}