From: Alex Lam S.L Date: Wed, 13 Mar 2019 13:56:38 +0000 (+0800) Subject: fix corner case in `reduce_vars` (#3332) X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=b052f62710df6b09caca2b82ff2303ad0079be58;p=UglifyJS.git fix corner case in `reduce_vars` (#3332) fixes #3267 --- diff --git a/lib/compress.js b/lib/compress.js index 75914b36..e6446fec 100644 --- a/lib/compress.js +++ b/lib/compress.js @@ -5787,8 +5787,8 @@ merge(Compressor.prototype, { } if (single_use && fixed) { def.single_use = false; + fixed._squeezed = true; if (fixed instanceof AST_Defun) { - fixed._squeezed = true; fixed = make_node(AST_Function, fixed, fixed); fixed.name = make_node(AST_SymbolLambda, fixed.name, fixed.name); } diff --git a/test/compress/reduce_vars.js b/test/compress/reduce_vars.js index 0bb682ab..32a06b10 100644 --- a/test/compress/reduce_vars.js +++ b/test/compress/reduce_vars.js @@ -6586,3 +6586,103 @@ issue_3240_4: { "1", ] } + +issues_3267_1: { + options = { + collapse_vars: true, + conditionals: true, + dead_code: true, + evaluate: true, + inline: true, + reduce_vars: true, + sequences: true, + side_effects: true, + unused: true, + } + input: { + (function(x) { + x(); + })(function() { + (function(i) { + if (i) + return console.log("PASS"); + throw "FAIL"; + })(Object()); + }); + } + expect: { + !function(i) { + if (i) + return console.log("PASS"); + throw "FAIL"; + }(Object()); + } + expect_stdout: "PASS" +} + +issues_3267_2: { + options = { + collapse_vars: true, + conditionals: true, + dead_code: true, + evaluate: true, + inline: true, + keep_fargs: false, + passes: 2, + reduce_vars: true, + sequences: true, + side_effects: true, + unused: true, + } + input: { + (function(x) { + x(); + })(function() { + (function(i) { + if (i) + return console.log("PASS"); + throw "FAIL"; + })(Object()); + }); + } + expect: { + !function() { + if (Object()) + return console.log("PASS"); + throw "FAIL"; + }(); + } + expect_stdout: "PASS" +} + +issues_3267_3: { + options = { + collapse_vars: true, + conditionals: true, + dead_code: true, + evaluate: true, + inline: true, + keep_fargs: false, + passes: 2, + reduce_vars: true, + sequences: true, + side_effects: true, + unsafe: true, + unused: true, + } + input: { + (function(x) { + x(); + })(function() { + (function(i) { + if (i) + return console.log("PASS"); + throw "FAIL"; + })(Object()); + }); + } + expect: { + console.log("PASS"); + } + expect_stdout: "PASS" +}