From: cjhjacobs <none@none>
Date: Wed, 18 May 2011 17:19:19 +0000 (+0200)
Subject: Fixed bug reported on tack-devel mailing list on 20-3-2011
X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=9f1aa5cae1aa773e90e4181c18c0596423ddf2f3;p=ack.git

Fixed bug reported on tack-devel mailing list on 20-3-2011
---

diff --git a/util/ass/ass80.c b/util/ass/ass80.c
index 66e5a31e1..614dbaf47 100644
--- a/util/ass/ass80.c
+++ b/util/ass/ass80.c
@@ -189,7 +189,13 @@ cons_t xgetarb(l,f) int l; FILE *f ; {
 
 	shift=0 ; val=0 ;
 	while ( l-- ) {
-		val += ((cons_t)(c = ctrunc(xgetc(f))))<<shift ;
+		// val += ((cons_t)(c = ctrunc(xgetc(f))))<<shift ;
+		// Bug here: shifts with too large shift counts
+		// get unspecified results. --Ceriel
+		c = ctrunc(xgetc(f));
+		if (shift < 8 * sizeof(cons_t)) {
+			val += ((cons_t)c)<<shift ;
+		}
 		shift += 8 ;
 	}
 	if (c == 0377 && shift > 8 && ((shift>>3)&1)) {