From: Jakub Pawlowicz Date: Fri, 15 May 2015 10:32:01 +0000 (+0100) Subject: Fixes #574 - rewriting internal URLs. X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=9aa5d624aa72405697dd89b34682520e5a42e87f;p=clean-css.git Fixes #574 - rewriting internal URLs. We should not rewrite URLs such as about:config etc. --- diff --git a/History.md b/History.md index 5573d6e5..1da7df07 100644 --- a/History.md +++ b/History.md @@ -12,6 +12,7 @@ * Fixed issue [#448](https://github.com/jakubpawlowicz/clean-css/issues/448) - rebasing no protocol URIs. * Fixed issue [#517](https://github.com/jakubpawlowicz/clean-css/issues/517) - turning off color optimizations. * Fixed issue [#542](https://github.com/jakubpawlowicz/clean-css/issues/542) - space after closing brace in IE. +* Fixed issue [#574](https://github.com/jakubpawlowicz/clean-css/issues/574) - rewriting internal URLs. [3.2.10 / 2015-05-14](https://github.com/jakubpawlowicz/clean-css/compare/v3.2.9...v3.2.10) ================== diff --git a/lib/urls/rewrite.js b/lib/urls/rewrite.js index af575008..54135003 100644 --- a/lib/urls/rewrite.js +++ b/lib/urls/rewrite.js @@ -17,6 +17,10 @@ function isEscaped(uri) { return uri.indexOf('__ESCAPED_URL_CLEAN_CSS__') === 0; } +function isInternal(uri) { + return /^\w+:\w+/.test(uri); +} + function isRemote(uri) { return uri.indexOf('http://') === 0 || uri.indexOf('https://') === 0 || uri.indexOf('//') === 0; } @@ -44,7 +48,7 @@ function normalize(uri) { } function rebase(uri, options) { - if (isAbsolute(uri) || isSVGMarker(uri) || isEscaped(uri)) + if (isAbsolute(uri) || isSVGMarker(uri) || isEscaped(uri) || isInternal(uri)) return uri; if (options.rebase === false && !isImport(uri)) diff --git a/test/integration-test.js b/test/integration-test.js index 330391a7..2138bda3 100644 --- a/test/integration-test.js +++ b/test/integration-test.js @@ -1082,6 +1082,10 @@ path")}', ], 'document-local reference': [ 'svg{marker-end:url(#arrow)}', 'svg{marker-end:url(#arrow)}' + ], + 'internal page': [ + 'a{background:url(about:blank)}', + 'a{background:url(about:blank)}' ] }, { root: process.cwd(),