From: Alex Lam S.L <alexlamsl@gmail.com>
Date: Wed, 10 Jun 2020 18:01:23 +0000 (+0100)
Subject: fix corner case in `unused` (#3987)
X-Git-Url: https://git.ndcode.org/public/gitweb.cgi?a=commitdiff_plain;h=596fad182e853f83960b6b659b8093aa8ad09fc6;p=UglifyJS.git

fix corner case in `unused` (#3987)

fixes #3986
---

diff --git a/lib/compress.js b/lib/compress.js
index 03432bee..0eaa3a4d 100644
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -4674,9 +4674,13 @@ merge(Compressor.prototype, {
             var rhs = assign.right;
             if (!assign.write_only) return rhs;
             if (!(rhs instanceof AST_Binary && lazy_op[rhs.operator])) return rhs;
-            var sym = assign.left;
-            if (!(sym instanceof AST_SymbolRef) || sym.name != rhs.left.name) return rhs;
-            return rhs.right.has_side_effects(compressor) ? rhs : rhs.right;
+            if (!(rhs.left instanceof AST_SymbolRef)) return rhs;
+            if (!(assign.left instanceof AST_SymbolRef)) return rhs;
+            var def = assign.left.definition();
+            if (rhs.left.definition() !== def) return rhs;
+            if (rhs.right.has_side_effects(compressor)) return rhs;
+            if (track_assigns(def, rhs.left)) add_assigns(def, rhs.left);
+            return rhs.right;
         }
 
         function scan_ref_scoped(node, descend, init) {
diff --git a/test/compress/drop-unused.js b/test/compress/drop-unused.js
index 8c912a57..b66320ad 100644
--- a/test/compress/drop-unused.js
+++ b/test/compress/drop-unused.js
@@ -2755,3 +2755,37 @@ issue_3962_2: {
     }
     expect_stdout: "PASS"
 }
+
+issue_3986: {
+    options = {
+        reduce_vars: true,
+        side_effects: true,
+        toplevel: true,
+        unused: true,
+    }
+    input: {
+        var a = 0, b = 0;
+        (function() {
+            try {
+                throw 42;
+            } catch (e) {
+                a++;
+            }
+            b = b && 0;
+        })(b *= a);
+        console.log(b);
+    }
+    expect: {
+        var a = 0, b = 0;
+        (function() {
+            try {
+                throw 42;
+            } catch (e) {
+                a++;
+            }
+            b = b && 0;
+        })(b *= a);
+        console.log(b);
+    }
+    expect_stdout: "0"
+}