Fix hoisting the var in ForIn
authorMihai Bazon <mihai.bazon@gmail.com>
Tue, 5 Jan 2016 11:56:52 +0000 (13:56 +0200)
committerMihai Bazon <mihai.bazon@gmail.com>
Tue, 5 Jan 2016 11:56:52 +0000 (13:56 +0200)
Close #913

lib/compress.js
test/compress/issue-913.js [new file with mode: 0644]

index 44e1979..1f5988f 100644 (file)
@@ -1276,7 +1276,10 @@ merge(Compressor.prototype, {
                             var seq = node.to_assignments();
                             var p = tt.parent();
                             if (p instanceof AST_ForIn && p.init === node) {
-                                if (seq == null) return node.definitions[0].name;
+                                if (seq == null) {
+                                    var def = node.definitions[0].name;
+                                    return make_node(AST_SymbolRef, def, def);
+                                }
                                 return seq;
                             }
                             if (p instanceof AST_For && p.init === node) {
diff --git a/test/compress/issue-913.js b/test/compress/issue-913.js
new file mode 100644 (file)
index 0000000..9d34d9d
--- /dev/null
@@ -0,0 +1,20 @@
+keep_var_for_in: {
+    options = {
+        hoist_vars: true,
+        unused: true
+    };
+    input: {
+        (function(obj){
+            var foo = 5;
+            for (var i in obj)
+                return foo;
+        })();
+    }
+    expect: {
+        (function(obj){
+            var i, foo = 5;
+            for (i in obj)
+                return foo;
+        })();
+    }
+}