C spec requires the ctype functions to be valid for unsigned chars, so

casting to char is invalid. We cast to uint8_t instead. Bonus: smaller
code!

--HG--
extra : source : b75c83c0539dd462bee151beab76938eca046294

diff --git a/Library/libs/isalnum.c b/Library/libs/isalnum.c
index e3d2cf0..511038d 100644 (file)
--- a/Library/libs/isalnum.c
+++ b/Library/libs/isalnum.c
@@ -1,3 +1,4 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isalnum(int c)

diff --git a/Library/libs/isalpha.c b/Library/libs/isalpha.c
index 0980d09..07208ce 100644 (file)
--- a/Library/libs/isalpha.c
+++ b/Library/libs/isalpha.c
@@ -1,3 +1,4 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isalpha(int c)

diff --git a/Library/libs/isascii.c b/Library/libs/isascii.c
index b4278f0..2bc3805 100644 (file)
--- a/Library/libs/isascii.c
+++ b/Library/libs/isascii.c
@@ -1,7 +1,9 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isascii(int c)
 {
-       return (c >= 0) && (c <= 127);
+       uint8_t cb = c;
+       return (cb >= 0) && (cb <= 127);
 }
 

diff --git a/Library/libs/iscntrl.c b/Library/libs/iscntrl.c
index 4d770e9..a0f7d30 100644 (file)
--- a/Library/libs/iscntrl.c
+++ b/Library/libs/iscntrl.c
@@ -1,7 +1,8 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int iscntrl(int c)
 {
-       char bc = c;
+       uint8_t bc = c;
        return ((bc >= 0) && (bc <= 31)) || (bc == 127);
 }

diff --git a/Library/libs/isdigit.c b/Library/libs/isdigit.c
index 7a3a2a9..669bb28 100644 (file)
--- a/Library/libs/isdigit.c
+++ b/Library/libs/isdigit.c
@@ -1,8 +1,9 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isdigit(int c)
 {
-       char bc = c;
+       uint8_t bc = c;
        return (bc >= '0') && (bc <= '9');
 }
 

diff --git a/Library/libs/isgraph.c b/Library/libs/isgraph.c
index d566013..fdc776e 100644 (file)
--- a/Library/libs/isgraph.c
+++ b/Library/libs/isgraph.c
@@ -1,3 +1,4 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isgraph(int c)

diff --git a/Library/libs/islower.c b/Library/libs/islower.c
index b63fce0..ba78d10 100644 (file)
--- a/Library/libs/islower.c
+++ b/Library/libs/islower.c
@@ -1,7 +1,8 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int islower(int c)
 {
-       char bc = c;
+       uint8_t bc = c;
        return (bc >= 'a') && (bc <= 'z');
 }

diff --git a/Library/libs/isoctal.c b/Library/libs/isoctal.c
index 3d69a06..a1a8622 100644 (file)
--- a/Library/libs/isoctal.c
+++ b/Library/libs/isoctal.c
@@ -1,8 +1,9 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isoctal(int c)
 {
-       char bc = c;
+       uint8_t bc = c;
        return (bc >= '0') && (bc <= '7');
 }
 

diff --git a/Library/libs/ispunct.c b/Library/libs/ispunct.c
index be72ef8..2c88fa4 100644 (file)
--- a/Library/libs/ispunct.c
+++ b/Library/libs/ispunct.c
@@ -1,3 +1,4 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int ispunct(int c)

diff --git a/Library/libs/isspace.c b/Library/libs/isspace.c
index 6cba2db..8cadeb5 100644 (file)
--- a/Library/libs/isspace.c
+++ b/Library/libs/isspace.c
@@ -1,3 +1,4 @@
+#include <stdint.h>
 #include <ctype.h>
 #include <string.h>
 

diff --git a/Library/libs/isupper.c b/Library/libs/isupper.c
index d2d3dd8..0dad20d 100644 (file)
--- a/Library/libs/isupper.c
+++ b/Library/libs/isupper.c
@@ -1,7 +1,8 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isupper(int c)
 {
-       char bc = c;
+       uint8_t bc = c;
        return (bc >= 'A') && (bc <= 'Z');
 }

diff --git a/Library/libs/isxdigit.c b/Library/libs/isxdigit.c
index 3da08f3..483e64b 100644 (file)
--- a/Library/libs/isxdigit.c
+++ b/Library/libs/isxdigit.c
@@ -1,8 +1,9 @@
+#include <stdint.h>
 #include <ctype.h>
 
 int isxdigit(int c)
 {
-       char bc = c;
+       uint8_t bc = c;
        return isdigit(bc)
                || ((bc >= 'a') && (bc <= 'f'))
                || ((bc >= 'A') && (bc <= 'F'));