fix `inline` on duplicate argument names (#2698)
authorAlex Lam S.L <alexlamsl@gmail.com>
Sun, 31 Dec 2017 12:59:58 +0000 (20:59 +0800)
committerGitHub <noreply@github.com>
Sun, 31 Dec 2017 12:59:58 +0000 (20:59 +0800)
lib/compress.js
test/compress/functions.js

index 604371f..56176e5 100644 (file)
@@ -4012,7 +4012,7 @@ merge(Compressor.prototype, {
             for (var len = fn.argnames.length, i = len; --i >= 0;) {
                 var name = fn.argnames[i];
                 var value = self.args[i];
-                if (name.__unused) {
+                if (name.__unused || scope.var_names()[name.name]) {
                     if (value) {
                         expressions.unshift(value);
                     }
index 888c6e3..e6c4301 100644 (file)
@@ -1646,3 +1646,28 @@ issue_2663_3: {
         "reset",
     ]
 }
+
+duplicate_argnames: {
+    options = {
+        inline: true,
+        reduce_vars: true,
+        side_effects: true,
+        toplevel: true,
+        unused: true,
+    }
+    input: {
+        var a = "PASS";
+        function f(b, b, b) {
+            b && (a = "FAIL");
+        }
+        f(0, console);
+        console.log(a);
+    }
+    expect: {
+        var a = "PASS";
+        console, b && (a = "FAIL");
+        var b;
+        console.log(a);
+    }
+    expect_stdout: "PASS"
+}