fix nested `inline` within loop (#3019)
authorAlex Lam S.L <alexlamsl@gmail.com>
Thu, 22 Mar 2018 18:31:59 +0000 (02:31 +0800)
committerGitHub <noreply@github.com>
Thu, 22 Mar 2018 18:31:59 +0000 (02:31 +0800)
fixes #3018

lib/compress.js
test/compress/functions.js

index fba88f4..aeff904 100644 (file)
@@ -4773,9 +4773,10 @@ merge(Compressor.prototype, {
                     var var_def = stat.definitions[j];
                     var name = var_def.name;
                     append_var(decls, expressions, name, var_def.value);
-                    if (in_loop) {
+                    if (in_loop && all(fn.argnames, function(argname) {
+                        return argname.name != name.name;
+                    })) {
                         var def = fn.variables.get(name.name);
-                        if (def.orig[0] instanceof AST_SymbolFunarg) continue;
                         var sym = make_node(AST_SymbolRef, name, name);
                         def.references.push(sym);
                         expressions.splice(pos++, 0, make_node(AST_Assign, var_def, {
index bbe94eb..ceaf064 100644 (file)
@@ -2208,3 +2208,32 @@ issue_3016_3_ie8: {
         "PASS",
     ]
 }
+
+issue_3018: {
+    options = {
+        inline: true,
+        side_effects: true,
+        toplevel: true,
+    }
+    input: {
+        var b = 1, c = "PASS";
+        do {
+            (function() {
+                (function(a) {
+                    a = 0 != (a && (c = "FAIL"));
+                })();
+            })();
+        } while (b--);
+        console.log(c);
+    }
+    expect: {
+        var b = 1, c = "PASS";
+        do {
+            a = void 0,
+            a = 0 != (a && (c = "FAIL"));
+        } while (b--);
+        var a;
+        console.log(c);
+    }
+    expect_stdout: "PASS"
+}