fix corner case in `loops` & `unused` (#4241)

fixes #4240

diff --git a/lib/compress.js b/lib/compress.js
index c6e27e0..216ca92 100644 (file)
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -5182,7 +5182,7 @@ merge(Compressor.prototype, {
                 var def = sym.definition();
                 if (!def) return;
                 if (def.id in in_use_ids) return;
-                if (def.scope !== self && member(def, self.enclosed)) return;
+                if (def.scope !== self && self.find_variable(sym) === def) return;
                 log(sym, "Dropping unused loop variable {name}");
                 if (for_ins[def.id] === node) delete for_ins[def.id];
                 var body = [];

diff --git a/test/compress/loops.js b/test/compress/loops.js
index cfabe6f..6915082 100644 (file)
--- a/test/compress/loops.js
+++ b/test/compress/loops.js
@@ -1222,3 +1222,35 @@ do_continue: {
     }
     expect_stdout: "PASS"
 }
+
+issue_4240: {
+    options = {
+        loops: true,
+        reduce_funcs: true,
+        reduce_vars: true,
+        unused: true,
+    }
+    input: {
+        (function(a) {
+            function f() {
+                var o = { PASS: 42 };
+                for (a in o);
+            }
+            (function() {
+                if (f());
+            })();
+            console.log(a);
+        })();
+    }
+    expect: {
+        (function(a) {
+            (function() {
+                if (function() {
+                    for (a in { PASS: 42 });
+                }());
+            })();
+            console.log(a);
+        })();
+    }
+    expect_stdout: "PASS"
+}