fix corner case in `collapse_vars` (#4605)
authorAlex Lam S.L <alexlamsl@gmail.com>
Mon, 1 Feb 2021 15:24:11 +0000 (15:24 +0000)
committerGitHub <noreply@github.com>
Mon, 1 Feb 2021 15:24:11 +0000 (23:24 +0800)
fixes #4604

lib/compress.js
test/compress/templates.js

index f894a6c..ac7aa3e 100644 (file)
@@ -1942,6 +1942,7 @@ merge(Compressor.prototype, {
                     var def = node.definition();
                     return (in_try || def.scope.resolve() !== scope) && !can_drop_symbol(node);
                 }
+                if (node instanceof AST_Template) return node.tag && !is_raw_tag(compressor, node.tag);
                 if (node instanceof AST_This) return symbol_in_lvalues(node, parent);
                 if (node instanceof AST_VarDef) {
                     if (check_destructured(node.name)) return true;
index ef2a534..3b0e983 100644 (file)
@@ -198,3 +198,27 @@ unsafe_side_effects: {
     expect_stdout: "foo"
     node_version: ">=4"
 }
+
+issue_4604: {
+    options = {
+        collapse_vars: true,
+    }
+    input: {
+        var a = 0, log = console.log;
+        a = "FAIL";
+        (function() {
+            a = "PASS";
+        })``;
+        log(a);
+    }
+    expect: {
+        var a = 0, log = console.log;
+        a = "FAIL";
+        (function() {
+            a = "PASS";
+        })``;
+        log(a);
+    }
+    expect_stdout: "PASS"
+    node_version: ">=4"
+}