Don't add empty string value to valueless attributes

diff --git a/src/htmlminifier.js b/src/htmlminifier.js
index bd7d928..950b9d1 100644 (file)
--- a/src/htmlminifier.js
+++ b/src/htmlminifier.js
@@ -267,7 +267,7 @@
 
     attrValue = cleanAttributeValue(tag, attrName, attrValue, options);
 
-    if (!options.removeAttributeQuotes ||
+    if (attrValue !== undefined && !options.removeAttributeQuotes ||
         !canRemoveAttributeQuotes(attrValue)) {
       attrValue = '"' + attrValue + '"';
     }
@@ -277,8 +277,8 @@
       return '';
     }
 
-    if (options.collapseBooleanAttributes &&
-        isBooleanAttribute(attrName)) {
+    if (attrValue === undefined || (options.collapseBooleanAttributes &&
+        isBooleanAttribute(attrName))) {
       attrFragment = attrName;
     }
     else {

diff --git a/src/htmlparser.js b/src/htmlparser.js
index d11272b..96d75ca 100644 (file)
--- a/src/htmlparser.js
+++ b/src/htmlparser.js
@@ -216,11 +216,11 @@
           var value = arguments[2] ? arguments[2] :
             arguments[3] ? arguments[3] :
             arguments[4] ? arguments[4] :
-            fillAttrs[name] ? name : '';
+            fillAttrs[name] ? name : arguments[2];
           attrs.push({
             name: name,
             value: value,
-            escaped: value.replace(/(^|[^\\])"/g, '$1"') //"
+            escaped: value && value.replace(/(^|[^\\])"/g, '$1"') //"
           });
         });
 

diff --git a/tests/minifier.js b/tests/minifier.js
index 5a42440..bd95345 100644 (file)
--- a/tests/minifier.js
+++ b/tests/minifier.js
@@ -35,7 +35,7 @@
     equal(minify('<ng-include src="x"></ng-include>'), '<ng-include src="x"></ng-include>');
     equal(minify('<ng:include src="x"></ng:include>'), '<ng:include src="x"></ng:include>');
     equal(minify('<ng-include src="\'views/partial-notification.html\'"></ng-include><div ng-view></div>'),
-      '<ng-include src="\'views/partial-notification.html\'"></ng-include><div ng-view=""></div>'
+      '<ng-include src="\'views/partial-notification.html\'"></ng-include><div ng-view></div>'
     );
 
     // https://github.com/kangax/html-minifier/issues/41