fix side-effects detection on switch statements (#1678)
authorAlex Lam S.L <alexlamsl@gmail.com>
Sun, 26 Mar 2017 04:05:44 +0000 (12:05 +0800)
committerGitHub <noreply@github.com>
Sun, 26 Mar 2017 04:05:44 +0000 (12:05 +0800)
extension of #1675

lib/compress.js
test/compress/issue-1673.js

index c57287b..8d8387f 100644 (file)
@@ -1610,6 +1610,10 @@ merge(Compressor.prototype, {
         def(AST_Block, function(compressor){
             return any(this.body, compressor);
         });
+        def(AST_Case, function(compressor){
+            return any(this.body, compressor)
+                || this.expression.has_side_effects(compressor);
+        });
         def(AST_Try, function(compressor){
             return any(this.body, compressor)
                 || this.bcatch && this.bcatch.has_side_effects(compressor)
index 59686ab..4628e37 100644 (file)
@@ -125,3 +125,35 @@ side_effects_label: {
     }
     expect_stdout: "PASS"
 }
+
+side_effects_switch: {
+    options = {
+        reduce_vars: true,
+        side_effects: true,
+        unused: true,
+    }
+    input: {
+        function f() {
+            function g() {
+                switch (0) {
+                  default:
+                  case console.log("PASS"):
+                }
+            }
+            g();
+        }
+        f();
+    }
+    expect: {
+        function f() {
+            (function() {
+                switch (0) {
+                  default:
+                  case console.log("PASS"):
+                }
+            })();
+        }
+        f();
+    }
+    expect_stdout: "PASS"
+}