fix corner case in `assignments` (#4522)

fixes #4521

diff --git a/lib/compress.js b/lib/compress.js
index fd0564c..bcffd8b 100644 (file)
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -9948,9 +9948,9 @@ merge(Compressor.prototype, {
                         operator: self.right.operator + "=",
                         left: self.left,
                         right: self.right.right,
-                    }).optimize(compressor);
+                    });
                 }
-                else if (self.right.right instanceof AST_SymbolRef
+                if (self.right.right instanceof AST_SymbolRef
                     && self.right.right.name == self.left.name
                     && ASSIGN_OPS_COMMUTATIVE[self.right.operator]
                     && !self.right.left.has_side_effects(compressor)) {
@@ -9959,7 +9959,7 @@ merge(Compressor.prototype, {
                         operator: self.right.operator + "=",
                         left: self.left,
                         right: self.right.left,
-                    }).optimize(compressor);
+                    });
                 }
             }
             if ((self.operator == "-=" || self.operator == "+="

diff --git a/test/compress/assignments.js b/test/compress/assignments.js
index 0f87f9a..5bc971a 100644 (file)
--- a/test/compress/assignments.js
+++ b/test/compress/assignments.js
@@ -461,3 +461,17 @@ issue_3949_2: {
     }
     expect_stdout: "100"
 }
+
+issue_4521: {
+    options = {
+        assignments: true,
+        dead_code: true,
+    }
+    input: {
+        var a = (a = 42 | a) ? console.log(a) : 0;
+    }
+    expect: {
+        var a = (a |= 42) ? console.log(a) : 0;
+    }
+    expect_stdout: "42"
+}