fix corner case in `merge_vars` (#4295)

fixes #4294

diff --git a/lib/compress.js b/lib/compress.js
index c1da6e7..e05b6f2 100644 (file)
--- a/lib/compress.js
+++ b/lib/compress.js
@@ -4750,6 +4750,8 @@ merge(Compressor.prototype, {
                         var ldef = node.variables.get(ref.name);
                         if (ldef && (ldef === def || def.undeclared || node.parent_scope.find_variable(ref) === def)) {
                             references[ldef.id] = false;
+                        } else {
+                            mark(ref, true, false);
                         }
                         return true;
                     });

diff --git a/test/compress/destructured.js b/test/compress/destructured.js
index 7eaad22..4ef2886 100644 (file)
--- a/test/compress/destructured.js
+++ b/test/compress/destructured.js
@@ -1470,3 +1470,35 @@ issue_4288: {
     expect_stdout: "undefined"
     node_version: ">=6"
 }
+
+issue_4294: {
+    options = {
+        merge_vars: true,
+    }
+    input: {
+        A = "PASS";
+        (function() {
+            var a = function({
+                [a]: {},
+            }) {}({
+                [a]: 0,
+            });
+            var b = A;
+            console.log(b);
+        })();
+    }
+    expect: {
+        A = "PASS";
+        (function() {
+            var a = function({
+                [a]: {},
+            }) {}({
+                [a]: 0,
+            });
+            var b = A;
+            console.log(b);
+        })();
+    }
+    expect_stdout: "PASS"
+    node_version: ">=6"
+}

diff --git a/test/reduce.js b/test/reduce.js
index f126573..2b1b42e 100644 (file)
--- a/test/reduce.js
+++ b/test/reduce.js
@@ -115,7 +115,7 @@ module.exports = function reduce_test(testcase, minify_options, reduce_options)
 
             // ignore lvalues
             if (parent instanceof U.AST_Assign && parent.left === node) return;
-            if (parent instanceof U.AST_Destructured) return;
+            if (parent instanceof U.AST_DestructuredArray) return;
             if (parent instanceof U.AST_DestructuredKeyVal && parent.value === node) return;
             if (parent instanceof U.AST_Unary && parent.expression === node) switch (parent.operator) {
               case "++":