fix corner case in `dead_code` (#4194)
authorAlex Lam S.L <alexlamsl@gmail.com>
Mon, 12 Oct 2020 03:09:26 +0000 (04:09 +0100)
committerGitHub <noreply@github.com>
Mon, 12 Oct 2020 03:09:26 +0000 (11:09 +0800)
fixes #4193

lib/compress.js
test/compress/const.js

index 7d5e022..c401203 100644 (file)
@@ -6571,14 +6571,17 @@ merge(Compressor.prototype, {
                         });
                     });
                 }
-                [].unshift.apply(body, self.body);
-                if (self.bfinally) [].push.apply(body, self.bfinally.body);
+                body.unshift(make_node(AST_BlockStatement, self, self).optimize(compressor));
+                if (self.bfinally) {
+                    body.push(make_node(AST_BlockStatement, self.bfinally, self.bfinally).optimize(compressor));
+                }
                 return make_node(AST_BlockStatement, self, {
                     body: body
                 }).optimize(compressor);
             }
             if (self.bfinally && has_declarations_only(self.bfinally)) {
-                var body = self.body.concat(self.bfinally.body);
+                var body = make_node(AST_BlockStatement, self.bfinally, self.bfinally).optimize(compressor);
+                body = self.body.concat(body);
                 if (!self.bcatch) return make_node(AST_BlockStatement, self, {
                     body: body
                 }).optimize(compressor);
index bc37e14..f09dc56 100644 (file)
@@ -725,3 +725,25 @@ issue_4191_2: {
     }
     expect_stdout: "function undefined"
 }
+
+issue_4193: {
+    options = {
+        dead_code: true,
+    }
+    input: {
+        try {} catch (e) {
+            var a;
+        } finally {
+            const a = 0;
+        }
+        console.log(a);
+    }
+    expect: {
+        var a;
+        {
+            const a = 0;
+        }
+        console.log(a);
+    }
+    expect_stdout: true
+}