fix corner case in `pure_getters` (#4615)
authorAlex Lam S.L <alexlamsl@gmail.com>
Fri, 5 Feb 2021 01:03:51 +0000 (01:03 +0000)
committerGitHub <noreply@github.com>
Fri, 5 Feb 2021 01:03:51 +0000 (09:03 +0800)
fixes #4614

lib/compress.js
test/compress/spreads.js

index 5e18e52..781b59f 100644 (file)
@@ -3441,7 +3441,7 @@ merge(Compressor.prototype, {
             if (is_undeclared_ref(this) && this.is_declared(compressor)) return false;
             if (this.is_immutable()) return false;
             var def = this.definition();
-            if (is_arguments(def) && all(def.scope.argnames, function(argname) {
+            if (is_arguments(def) && !def.scope.rest && all(def.scope.argnames, function(argname) {
                 return argname instanceof AST_SymbolFunarg;
             })) return def.scope.uses_arguments > 2;
             var fixed = this.fixed_value();
index 7eac248..a3a7003 100644 (file)
@@ -918,3 +918,32 @@ issue_4560_3: {
     expect_stdout: "PASS"
     node_version: ">=6"
 }
+
+issue_4614: {
+    options = {
+        pure_getters: "strict",
+        side_effects: true,
+    }
+    input: {
+        try {
+            (function(...[]) {
+                var arguments;
+                arguments[0];
+            })();
+        } catch (e) {
+            console.log("PASS");
+        }
+    }
+    expect: {
+        try {
+            (function(...[]) {
+                var arguments;
+                arguments[0];
+            })();
+        } catch (e) {
+            console.log("PASS");
+        }
+    }
+    expect_stdout: true
+    node_version: ">=6"
+}