fix corner case in `unused` (#4145)
authorAlex Lam S.L <alexlamsl@gmail.com>
Tue, 22 Sep 2020 06:03:27 +0000 (07:03 +0100)
committerGitHub <noreply@github.com>
Tue, 22 Sep 2020 06:03:27 +0000 (14:03 +0800)
fixes #4144

lib/compress.js
test/compress/drop-unused.js

index f66b718..66ed143 100644 (file)
@@ -6474,7 +6474,7 @@ merge(Compressor.prototype, {
                     side_effects.push(node);
                     args[pos++] = make_sequence(call, side_effects);
                     side_effects = [];
-                } else if (!trim) {
+                } else if (!trim && fn.argnames[i].__unused) {
                     if (side_effects.length) {
                         node = make_sequence(call, side_effects);
                         side_effects = [];
index eadf279..219adc9 100644 (file)
@@ -2945,3 +2945,23 @@ issue_4133: {
     }
     expect_stdout: "0"
 }
+
+issue_4144: {
+    options = {
+        keep_fargs: "strict",
+        reduce_vars: true,
+        unused: true,
+    }
+    input: {
+        (function(a, b) {
+            var b = console, c = ++b;
+        })(console.log("PASS"), 0);
+    }
+    expect: {
+        (function(b) {
+            b = console,
+            ++b;
+        })(console.log("PASS"));
+    }
+    expect_stdout: "PASS"
+}