fix nested `inline` (#2602)
authorAlex Lam S.L <alexlamsl@gmail.com>
Fri, 15 Dec 2017 18:16:35 +0000 (02:16 +0800)
committerGitHub <noreply@github.com>
Fri, 15 Dec 2017 18:16:35 +0000 (02:16 +0800)
fixes #2601

lib/compress.js
test/compress/functions.js

index 0fac325..8c17422 100644 (file)
@@ -3942,6 +3942,7 @@ merge(Compressor.prototype, {
                         expressions.unshift(value || make_node(AST_Undefined, self));
                     }
                 } else {
+                    scope.var_names()[name.name] = true;
                     decls.unshift(make_node(AST_VarDef, name, {
                         name: name,
                         value: null
index a36509a..8e67bc3 100644 (file)
@@ -772,3 +772,78 @@ issue_2476: {
     }
     expect_stdout: "465"
 }
+
+issue_2601_1: {
+    options = {
+        inline: true,
+        reduce_vars: true,
+        sequences: true,
+        side_effects: true,
+        unused: true,
+    }
+    input: {
+        var a = "FAIL";
+        (function() {
+            function f(b) {
+                function g(b) {
+                    b && b();
+                }
+                g();
+                (function() {
+                    b && (a = "PASS");
+                })();
+            }
+            f("foo");
+        })();
+        console.log(a);
+    }
+    expect: {
+        var a = "FAIL";
+        (function() {
+            b = "foo",
+            function(b) {
+                b && b();
+            }(),
+            b && (a = "PASS");
+            var b;
+        })(),
+        console.log(a);
+    }
+    expect_stdout: "PASS"
+}
+
+issue_2601_2: {
+    rename = true
+    options = {
+        evaluate: true,
+        inline: true,
+        passes: 3,
+        reduce_vars: true,
+        sequences: true,
+        side_effects: true,
+        unused: true,
+    }
+    mangle = {}
+    input: {
+        var a = "FAIL";
+        (function() {
+            function f(b) {
+                function g(b) {
+                    b && b();
+                }
+                g();
+                (function() {
+                    b && (a = "PASS");
+                })();
+            }
+            f("foo");
+        })();
+        console.log(a);
+    }
+    expect: {
+        var a = "FAIL";
+        a = "PASS",
+        console.log(a);
+    }
+    expect_stdout: "PASS"
+}