fix corner case in `pure_getters` (#4441)
authorAlex Lam S.L <alexlamsl@gmail.com>
Wed, 23 Dec 2020 20:09:09 +0000 (20:09 +0000)
committerGitHub <noreply@github.com>
Wed, 23 Dec 2020 20:09:09 +0000 (04:09 +0800)
fixes #4440

lib/compress.js
test/compress/pure_getters.js

index c397a60..13b7306 100644 (file)
@@ -3237,7 +3237,8 @@ merge(Compressor.prototype, {
             if (!is_strict(compressor)) return false;
             if (is_undeclared_ref(this) && this.is_declared(compressor)) return false;
             if (this.is_immutable()) return false;
-            if (is_arguments(this.definition())) return false;
+            var def = this.definition();
+            if (is_arguments(def)) return def.scope.uses_arguments > 2;
             var fixed = this.fixed_value();
             if (!fixed) return true;
             this._dot_throw = return_true;
index 25efd7f..1cb2ff1 100644 (file)
@@ -1208,3 +1208,32 @@ issue_3427: {
     expect: {}
     expect_stdout: true
 }
+
+issue_4440: {
+    options = {
+        pure_getters: "strict",
+        side_effects: true,
+        unused: true,
+    }
+    input: {
+        try {
+            (function() {
+                arguments = null;
+                console.log(arguments.p = "FAIL");
+            })();
+        } catch (e) {
+            console.log("PASS");
+        }
+    }
+    expect: {
+        try {
+            (function() {
+                arguments = null;
+                console.log(arguments.p = "FAIL");
+            })();
+        } catch (e) {
+            console.log("PASS");
+        }
+    }
+    expect_stdout: "PASS"
+}