fix corner case in `evaluate` (#3559)
authorAlex Lam S.L <alexlamsl@gmail.com>
Thu, 31 Oct 2019 16:01:25 +0000 (00:01 +0800)
committerGitHub <noreply@github.com>
Thu, 31 Oct 2019 16:01:25 +0000 (00:01 +0800)
fixes #3558

lib/compress.js
test/compress/evaluate.js

index a6f5d20..65768c0 100644 (file)
@@ -2862,10 +2862,10 @@ merge(Compressor.prototype, {
               case "+": return +v;
               case "++":
               case "--":
-                if (e instanceof AST_SymbolRef) {
-                    var refs = e.definition().references;
-                    if (refs[refs.length - 1] === e) return v;
-                }
+                if (!(e instanceof AST_SymbolRef)) return this;
+                var refs = e.definition().references;
+                if (refs[refs.length - 1] !== e) return this;
+                return HOP(e, "_eval") ? +(this.operator[0] + 1) + +v : v;
             }
             return this;
         });
index 771bd4f..6eadbe5 100644 (file)
@@ -1838,3 +1838,24 @@ recursive_function_2: {
     }
     expect_stdout: "120"
 }
+
+issue_3558: {
+    options = {
+        evaluate: true,
+        reduce_vars: true,
+        toplevel: true,
+    }
+    input: {
+        function f(a) {
+            return 1 + --a;
+        }
+        console.log(f(true), f(false));
+    }
+    expect: {
+        function f(a) {
+            return 1 + --a;
+        }
+        console.log(1, 0);
+    }
+    expect_stdout: "1 0"
+}