fix corner case in `inline` (#4389)
authorAlex Lam S.L <alexlamsl@gmail.com>
Thu, 17 Dec 2020 16:55:19 +0000 (16:55 +0000)
committerGitHub <noreply@github.com>
Thu, 17 Dec 2020 16:55:19 +0000 (00:55 +0800)
fixes #4388

lib/compress.js
test/compress/arrows.js

index ffc19b2..2c50cb3 100644 (file)
@@ -8026,8 +8026,14 @@ merge(Compressor.prototype, {
                 }));
                 if (found) return false;
             }
-            var safe_to_inject = (!(scope instanceof AST_Toplevel) || compressor.toplevel.vars)
-                && (exp !== fn || fn.parent_scope.resolve() === scope);
+            var safe_to_inject = exp !== fn || fn.parent_scope.resolve() === scope;
+            if (scope instanceof AST_Toplevel) {
+                if (compressor.toplevel.vars) {
+                    defined["arguments"] = true;
+                } else {
+                    safe_to_inject = false;
+                }
+            }
             var inline = compressor.option("inline");
             var used = Object.create(defined);
             if (!can_inject_args(defined, used, inline >= 2 && safe_to_inject)) return false;
index 02c4acd..eded913 100644 (file)
@@ -336,3 +336,18 @@ trim_body: {
     expect_stdout: "PASS undefined"
     node_version: ">=4"
 }
+
+issue_4388: {
+    options = {
+        inline: true,
+        toplevel: true,
+    }
+    input: {
+        (arguments => console.log(arguments && arguments))();
+    }
+    expect: {
+        (arguments => console.log(arguments && arguments))();
+    }
+    expect_stdout: "undefined"
+    node_version: ">=4"
+}