Using assignments as truth values seems to have been a favoured

Using assignments as truth values seems to have been a favoured
programming style of Mr Bourne. gcc moans about it though:

"suggest parentheses around assignment used as truth value"

so in the interests of fewer compile warnings I have complied with the
suggestion.